Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #20140: Fix compatibility with PHP 8.4: calling session_set_save_handler() #20289

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Fix #20140: Fix compatibility with PHP 8.4: calling session_set_save_handler() #20289

merged 3 commits into from
Dec 6, 2024
+106 −31

Conversation

Izumi-kun
Copy link
Contributor

… 8.4

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ✔️
Fixed issues #20140

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (80f2545) to head (6349d57).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
framework/web/SessionHandler.php 71.42% 4 Missing ⚠️
framework/web/Session.php 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #20289      +/-   ##
============================================
- Coverage     64.85%   64.85%   -0.01%     
- Complexity    11402    11409       +7     
============================================
  Files           430      431       +1     
  Lines         37140    37142       +2     
============================================
+ Hits          24086    24087       +1     
- Misses        13054    13055       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark added this to the 2.0.52 milestone Dec 6, 2024
@samdark samdark added the php8 label Dec 6, 2024
samdark
samdark reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍

framework/CHANGELOG.md Outdated Show resolved Hide resolved
@samdark samdark requested review from a team December 6, 2024 09:30
@samdark samdark merged commit 65e3369 into yiisoft:master Dec 6, 2024
87 checks passed
@samdark samdark changed the title Fix #20140: PHP Deprecated: Calling session_set_save_handler() in PHP 8.4 Fix #20140: Fix compatibility with PHP 8.4: calling session_set_save_handler() Dec 6, 2024
@samdark
Copy link
Member

samdark commented Dec 6, 2024

Thank you!

@Izumi-kun Izumi-kun deleted the fix20140 branch December 6, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark left review comments

@bizley bizley bizley approved these changes

Assignees
No one assigned
Labels
php8
Projects
None yet
Milestone
2.0.52
Development

Successfully merging this pull request may close these issues.
3 participants
@Izumi-kun @samdark @bizley